refactor: seperate solving from installing #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added fancy progress now:
|
|
This is now passing CI and ready for a review! @wolfv ! |
wolfv
reviewed
Sep 6, 2024
|
|
||
| // use the configured style | ||
| if let Some(template) = &self.progress_template { | ||
| progress_bar.set_style(template.clone()); | ||
| } | ||
|
|
||
| // progress_bar.enable_steady_tick(Duration::from_millis(100)); |
There was a problem hiding this comment.
Suggested change
| // progress_bar.enable_steady_tick(Duration::from_millis(100)); |
|
Functionality is great! I am happy to merge. The only thing I found when testing is that the indent doesn't seem to be quite correct (screenshot attached). Maybe we should start a new tracing span that says "installing environments"? 
|
|
Also the bar from download & extract doesn't "go away" (but that's also a super minor thing). |
|
I think I fixed that the progress bars are now removed. The indentation is correct because there normally (before it finishes) is another progress bar above it. See the screenshot here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits solving the dependencies from the installation of the environments. This can make
--render-onlymuch faster because no installation is needed.Determining the
run_exportsis still part of solving. The packages are still downloaded and extracted to get the run_exports (that's an improvement for later). ThePackageCacheis now shared which ensures that validation/download/extract is not duplicated (which was previously the case).The gateway is also shared between all runs to reduce overhead.
I also removed storing a number of CLI arguments in
Configuration. These didnt make sense to me to store in the configuration and instead could better be passed as arguments to the functions that require them.However, currently the download progress of packages is lost. I wanna fix this before we merge.